Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11923 )
Change subject: [location_awareness] Register client with location when connect to cluster ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/11923/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11923/5//COMMIT_MSG@10 PS5, Line 10: After that, the client can compare its : location with the replica locations to select which replica to read Just to clarify: that's going to be published as a separate changelist, right? http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/11923/5/src/kudu/master/master-test.cc@1627 PS5, Line 1627: const string kLocationCmdPath = JoinPathSegments(GetTestExecutableDirectory(), : "testdata/first_argument.sh"); A generic note regarding the location scripts: once a test starts using a helper script, it's necessary to update its entry in CMakeLists.txt to include the script into the DATA_FILES. In other words, once a test becomes depending on some file, that dependency should be tracked. You could take a look at the entry for ts_descriptor-test as an example. -- To view, visit http://gerrit.cloudera.org:8080/11923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0efb327293d86168a30b05305f69d011ad15587a Gerrit-Change-Number: 11923 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 13 Nov 2018 22:01:27 +0000 Gerrit-HasComments: Yes
