Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )
Change subject: [c++] remove -Wno-deprecated compiler's flag ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/12140/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12140/2//COMMIT_MSG@11 PS2, Line 11: 'pragma GCC diagnostic' These don't cause warnings when building with clang do they? http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/12140/2/src/kudu/client/schema.h@253 PS2, Line 253: #pragma GCC diagnostic push This being client/schema.h, is this pragma recognized by el6's version of gcc? -- To view, visit http://gerrit.cloudera.org:8080/12140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759 Gerrit-Change-Number: 12140 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 02 Jan 2019 18:07:21 +0000 Gerrit-HasComments: Yes
