Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )
Change subject: [c++] remove -Wno-deprecated compiler's flag ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12140/3/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/12140/3/src/kudu/client/schema.h@254 PS3, Line 254: (defined(COMPILER_GCC) && (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40600) I see we use COMPILER_GCC elsewhere in the codebase, but I don't think it's actually defined. It's not a standard definition as per the gcc documentation, nor does it appear to be defined in my gcc: $ g++ -dM -E -x c++ - < /dev/null | grep COMPILER_GCC $ gcc -dM -E - < /dev/null | grep COMPILER_GCC I suspect it's from imported Chromium/Supersonic code, and that it's defined centrally in that codebase somewhere. -- To view, visit http://gerrit.cloudera.org:8080/12140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759 Gerrit-Change-Number: 12140 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 04 Jan 2019 19:35:30 +0000 Gerrit-HasComments: Yes
