Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )
Change subject: [c++] remove -Wno-deprecated compiler's flag ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12140/3/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/12140/3/src/kudu/client/schema.h@254 PS3, Line 254: (defined(COMPILER_GCC) && (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40600) > I see we use COMPILER_GCC elsewhere in the codebase, but I don't think it's Good catch -- I didn't verify that. Using __GNUC__ should be more than enough then. -- To view, visit http://gerrit.cloudera.org:8080/12140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759 Gerrit-Change-Number: 12140 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 04 Jan 2019 21:53:31 +0000 Gerrit-HasComments: Yes
