Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 )
Change subject: [c++] remove -Wno-deprecated compiler's flag ...................................................................... Patch Set 4: > Please test the C++ samples build on an el6.6 machine to make sure > you get the desired behavior in client/schema.h. Yep, that I verified: ve0518:examples$ cmake -G "Unix Makefiles" -DkuduClient_DIR=/tmp/xxx/usr/local/share/kuduClient/cmake -DCMAKE_BUILD_TYPE=debug -- Configuring done -- Generating done -- Build files have been written to: /tmp/xxx/usr/local/share/doc/kuduClient/examples ve0518:examples$ pwd /tmp/xxx/usr/local/share/doc/kuduClient/examples ve0518:examples$ make Scanning dependencies of target example [100%] Building CXX object CMakeFiles/example.dir/example.cc.o Linking CXX executable example [100%] Built target example ve0518:examples$ -- To view, visit http://gerrit.cloudera.org:8080/12140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I513bd49642755dbcb7ed405391fb13096ee49759 Gerrit-Change-Number: 12140 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 05 Jan 2019 00:31:07 +0000 Gerrit-HasComments: No
