Brian McDevitt has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12310 )

Change subject: [build] Fix mini cluster binary relocation on Mac OS
......................................................................


Patch Set 1:

(1 comment)

Looks good, just a question about the removal of "copymode".

http://gerrit.cloudera.org:8080/#/c/12310/1/build-support/relocate_binaries_for_mini_cluster.py
File build-support/relocate_binaries_for_mini_cluster.py:

http://gerrit.cloudera.org:8080/#/c/12310/1/build-support/relocate_binaries_for_mini_cluster.py@225
PS1, Line 225:     shutil.copy(src, dest)
The shutil.copymode() isn't needed anymore?



--
To view, visit http://gerrit.cloudera.org:8080/12310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib653b175ba2d0e5563509aecac372c9829eca2f5
Gerrit-Change-Number: 12310
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Brian McDevitt <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Comment-Date: Wed, 30 Jan 2019 16:13:07 +0000
Gerrit-HasComments: Yes

Reply via email to