Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 )
Change subject: [build] Fix mini cluster binary relocation on Mac OS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12310/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12310/1//COMMIT_MSG@14 PS1, Line 14: This patch changes the copy_file method to ignore files : that already exist. > Since the lib relocation work happens every time this is run, I would expec It would be a good improvement to blow away the destination directory each time and current we don't do that. -- To view, visit http://gerrit.cloudera.org:8080/12310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib653b175ba2d0e5563509aecac372c9829eca2f5 Gerrit-Change-Number: 12310 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 Jan 2019 18:55:35 +0000 Gerrit-HasComments: Yes
