Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 )
Change subject: [build] Fix mini cluster binary relocation on Mac OS ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12310/2/build-support/relocate_binaries_for_mini_cluster.py File build-support/relocate_binaries_for_mini_cluster.py: http://gerrit.cloudera.org:8080/#/c/12310/2/build-support/relocate_binaries_for_mini_cluster.py@226 PS2, Line 226: os.chmod(dest, stat.S_IRWXU | stat.S_IRGRP | stat.S_IXGRP | stat.S_IROTH | stat.S_IXOTH) > I am not sure why we want dynlibs to be executable. However I recall now th If preserving the metadata took a lot of work I'd be inclined to agree, but it's really just the one copymode() call (and possibly copystat() for good measure). Why not leave it in so that at least in the archive directory, the copied dependencies have preserved metadata? Regardless of how the files are eventually packaged up, this script is an archival script, so I think it should behave like one if it's easy to do so. -- To view, visit http://gerrit.cloudera.org:8080/12310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib653b175ba2d0e5563509aecac372c9829eca2f5 Gerrit-Change-Number: 12310 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 Jan 2019 19:28:20 +0000 Gerrit-HasComments: Yes
