Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 )
Change subject: [build] Fix mini cluster binary relocation on Mac OS ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12310/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12310/1//COMMIT_MSG@9 PS1, Line 9: On Mac OS the ssl libs like `libssl.1.0.0.dylib` are read only. : When relocate_binaries_for_mini_cluster.py tries to copy : these read only libs, the build fails because the file : already exists and cannot be replaced. > My lib directory is `drwxr-xr-x` and the libssl file with the issue is `-r- Ah, so copyfile() doesn't unlink() or rename(). You should unlink() the destination file before copyfile() then. http://gerrit.cloudera.org:8080/#/c/12310/1//COMMIT_MSG@14 PS1, Line 14: This patch changes the copy_file method to ensure copied : files have 755 perm > It would be a good improvement to blow away the destination directory each +1; if we don't blow it away and a dependency is _dropped_ between runs, we'll keep shipping that (now unnecessary) dependency anyway. http://gerrit.cloudera.org:8080/#/c/12310/1/build-support/relocate_binaries_for_mini_cluster.py File build-support/relocate_binaries_for_mini_cluster.py: http://gerrit.cloudera.org:8080/#/c/12310/1/build-support/relocate_binaries_for_mini_cluster.py@225 PS1, Line 225: shutil.copyfile(src, dest) > We were using copymode to ensure that executable files remain executable in I think mtime and atime are important. Since we're effectively archiving a file, we should do the best we can preserving all of its metadata, just as tar or some other tool would. It helps when troubleshooting issues (i.e. you can compare the mtime of an unarchived file with the mtime of the source file on the machine where the archive was built). -- To view, visit http://gerrit.cloudera.org:8080/12310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib653b175ba2d0e5563509aecac372c9829eca2f5 Gerrit-Change-Number: 12310 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 Jan 2019 19:17:17 +0000 Gerrit-HasComments: Yes
