Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12512 )
Change subject: [client] extra validation on rows upon Session::Apply() ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/client-test.cc@5887 PS1, Line 5887: ASSERT_OK(session->SetFlushMode(KuduSession::MANUAL_FLUSH)); Would AUTO_FLUSH_SYNC help shorten these tests by obviating the need for an explicit Flush() call? Maybe you could reduce another LOC or two by testing each case through a lambda that takes care of session creation, op application, and flushing? http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/write_op.h File src/kudu/client/write_op.h: http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/write_op.h@107 PS1, Line 107: spot spotted http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/write_op.h@111 PS1, Line 111: virtual Status Verify() const; Is this safe from an ABI compatibility perspective? The KDE wiki suggests the answer is 'no' (https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B), but I'm wondering whether it's only an issue for applications that subclass a base class that we provide, which isn't the case here (i.e. we don't expect third parties to subclass KuduWriteOperation). Anyway, you could do the validation within KuduSession using a switch on type(), thus obviating the need for a new virtual function. -- To view, visit http://gerrit.cloudera.org:8080/12512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I822f20f3242df7983c63ac146f298acfcfbafc68 Gerrit-Change-Number: 12512 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Feb 2019 20:28:04 +0000 Gerrit-HasComments: Yes
