Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12512 )
Change subject: [client] extra validation on rows upon Session::Apply() ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12512/2/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: http://gerrit.cloudera.org:8080/#/c/12512/2/src/kudu/client/session-internal.cc@331 PS2, Line 331: namespace { > What's the justification for 'inline' in the new Check functions? After some consideration I think the compiler knows better whether to inline or not, so I decided to remove 'inline' since I cannot present any justification this time. http://gerrit.cloudera.org:8080/#/c/12512/2/src/kudu/client/session-internal.cc@372 PS2, Line 372: FALLTHROUGH_INTENDED; > Nit: not necessary for truly empty cases. I think it's only really necessar Done -- To view, visit http://gerrit.cloudera.org:8080/12512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I822f20f3242df7983c63ac146f298acfcfbafc68 Gerrit-Change-Number: 12512 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Feb 2019 00:35:56 +0000 Gerrit-HasComments: Yes
