Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12512 )
Change subject: [client] extra validation on rows upon Session::Apply() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/write_op.h File src/kudu/client/write_op.h: http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/write_op.h@111 PS1, Line 111: virtual Status Verify() const; > Is this safe from an ABI compatibility perspective? The KDE wiki suggests t The way of calling type() was the first route I tried to use, but it didn't work. The issue was due to the problem declaring a private sub-class to be a friend of another class. I.e., I could not figure out how to declare KuduSession::Data to be a friend to KuduWriteOperation. I'm not sure that's possible in C++. However, there might be other way around. I liked the solution with the Verify() method since it looked better from the conceptual point. -- To view, visit http://gerrit.cloudera.org:8080/12512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I822f20f3242df7983c63ac146f298acfcfbafc68 Gerrit-Change-Number: 12512 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Feb 2019 21:02:59 +0000 Gerrit-HasComments: Yes
