Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12512 )
Change subject: [client] extra validation on rows upon Session::Apply() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/client-test.cc@5887 PS1, Line 5887: ASSERT_OK(session->SetFlushMode(KuduSession::MANUAL_FLUSH)); > I wanted to see that the error comes from Apply(), and not from the underly I switched to AUTO_FLUSH_SYNC for the success cases. I tried to use lambdas for session creation and other cruft, but not so much of benefits. http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/write_op.h File src/kudu/client/write_op.h: http://gerrit.cloudera.org:8080/#/c/12512/1/src/kudu/client/write_op.h@107 PS1, Line 107: spot > spotted Done -- To view, visit http://gerrit.cloudera.org:8080/12512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I822f20f3242df7983c63ac146f298acfcfbafc68 Gerrit-Change-Number: 12512 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Feb 2019 00:12:50 +0000 Gerrit-HasComments: Yes
