Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... Patch Set 12: (2 comments) Only a couple small nits. http://gerrit.cloudera.org:8080/#/c/12517/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12517/11//COMMIT_MSG@24 PS11, Line 24: inclued nit: included http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/util/flags.h File src/kudu/util/flags.h: http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/util/flags.h@58 PS11, Line 58: // Should be called after logging is initialized. Otherwise : // logging will write to stderr. nit: This was a little surprising because it implies that it has an effect on where we'll log, which isn't captured by its description. Also maybe explicitly say what initialization function needs to be called (if one exists)? -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 12 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 23:12:56 +0000 Gerrit-HasComments: Yes
