Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support starting master and tablet server via the kudu binary ...................................................................... Patch Set 11: (2 comments) a few quick thoughts from scanning the pathc. didn't look in great detail http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/tools/tool_action.h File src/kudu/tools/tool_action.h: http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/tools/tool_action.h@212 PS11, Line 212: ActionBuilder& ProgramName(const std::string& program_name); what do you think about abusing gflags here and using SetArgv and ProgramInvocationName? http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/12517/11/src/kudu/tools/tool_action_tserver.cc@216 PS11, Line 216: AddOptionalParameter do you think we could do this by tagging flags? eg TAG_FLAG(fs_metadata_dir, tserver_usage) or something? And then just discover all the flags that are tagged as such? We might want this for docs purposes as well -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 11 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 22:28:13 +0000 Gerrit-HasComments: Yes
