Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12512 )
Change subject: [client] extra validation on rows upon Session::Apply() ...................................................................... [client] extra validation on rows upon Session::Apply() This patch adds an extra validation step at the C++ client side for INSERT and UPSERT write operations prior sending them to tablet servers. More specifically, with this patch the Kudu C++ client verifies that each non-nullable column without default value is set for INSERT and UPSERT write operations before submitting WriteRequestPB to a tablet server. The verification is done upon calling KuduSession::Apply(). Also, a new test was added to cover the new functionality. Change-Id: I822f20f3242df7983c63ac146f298acfcfbafc68 Reviewed-on: http://gerrit.cloudera.org:8080/12512 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/client/client-test.cc M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/client/write_op.h 4 files changed, 151 insertions(+), 9 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I822f20f3242df7983c63ac146f298acfcfbafc68 Gerrit-Change-Number: 12512 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
