Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12512 )
Change subject: [client] extra validation on rows upon Session::Apply() ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12512/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/12512/3/src/kudu/client/client-test.cc@5954 PS3, Line 5954: // Do delete a row, only the key is necessary. : { : shared_ptr<KuduSession> session = client_->NewSession(); : ASSERT_OK(session->SetFlushMode(KuduSession::AUTO_FLUSH_SYNC)); : unique_ptr<KuduDelete> op(client_table_->NewDelete()); : auto* row = op->mutable_row(); : ASSERT_OK(row->SetInt32("key", 0)); : ASSERT_OK(session->Apply(op.release())); : } > Delete behavior is unchanged with this patch, right? Correct -- nothing has changed with regard to UPDATE and DELETE operations in this patch. I added this sub-scenario to cover possible regressions, if any, for DELETE write operations. I added similar for sub-scenario for the UPDATE as well. -- To view, visit http://gerrit.cloudera.org:8080/12512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I822f20f3242df7983c63ac146f298acfcfbafc68 Gerrit-Change-Number: 12512 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Feb 2019 01:34:56 +0000 Gerrit-HasComments: Yes
