Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12586 )
Change subject: KUDU-2710: Fix KeepAliveRequest retries ...................................................................... Patch Set 2: (2 comments) The http://gerrit.cloudera.org:8080/#/c/12586/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12586/2//COMMIT_MSG@10 PS2, Line 10: implimentation implementation http://gerrit.cloudera.org:8080/#/c/12586/2/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java: http://gerrit.cloudera.org:8080/#/c/12586/2/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java@63 PS2, Line 63: private static int staticNumFail = 0; : private static Exception staticException = null; Not a huge fan of this approach, in part because once activated the injected errors are entirely deterministic (i.e. unlike the kinds of faults injected in fault_injection.h), and in part because it's tough to reason about the interaction with ongoing RPCs; for example, is it possible for failNextRpcs() to race with sendRpc()? As an alternative, how about reducing the RPC service queue length to 1 as Andrew suggested, then hammering the server with keep alive requests? If you used the async API (i.e. AsyncKuduScanner.keepAlive()), you could queue up dozens of requests client-side, which should pretty much guarantee at least one queue overflow and retry. If the mini-cluster API allowed for easy metric access you could even loop until the overflow metric increased, but that's not possible right now. -- To view, visit http://gerrit.cloudera.org:8080/12586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I951212ab76079e5788c2870223b45782b16509e7 Gerrit-Change-Number: 12586 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 06:40:32 +0000 Gerrit-HasComments: Yes
