Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12586 )
Change subject: KUDU-2710: Fix KeepAliveRequest retries ...................................................................... Patch Set 3: LGTM beyond Adar's comment about tests. Can you try cooking up a regression test quickly along the lines of his recommendation? If it's too hard to make it consistent then I'd be OK with the current test in order to get this patch in an unblock 1.9. -- To view, visit http://gerrit.cloudera.org:8080/12586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I951212ab76079e5788c2870223b45782b16509e7 Gerrit-Change-Number: 12586 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 18:30:05 +0000 Gerrit-HasComments: No
