Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12586 )
Change subject: KUDU-2710: Fix KeepAliveRequest retries ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12586/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/12586/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@867 PS3, Line 867: public byte[] partitionKey() Could we mark the method abstract in the base abstract class KuduRpc? -- To view, visit http://gerrit.cloudera.org:8080/12586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I951212ab76079e5788c2870223b45782b16509e7 Gerrit-Change-Number: 12586 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 21:41:14 +0000 Gerrit-HasComments: Yes
