Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12586 )
Change subject: KUDU-2710: Fix KeepAliveRequest retries ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12586/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12586/2//COMMIT_MSG@10 PS2, Line 10: implimentation > implementation Done http://gerrit.cloudera.org:8080/#/c/12586/2/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java: http://gerrit.cloudera.org:8080/#/c/12586/2/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java@63 PS2, Line 63: private static int staticNumFail = 0; : private static Exception staticException = null; I am open to better approaches and can get more creative today with them, I went with this approach in part to get a patch out quickly. > As an alternative, how about reducing the RPC service queue length to 1 as > Andrew suggested, then hammering the server with keep alive requests? The reason I didn't go with this approach is because it is far less deterministic than the approach here. With the approach currently taken I know when I call failNextRpcs that no other RPCs are currently happening and that the next RPCs will be KeepAliveRequests. -- To view, visit http://gerrit.cloudera.org:8080/12586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I951212ab76079e5788c2870223b45782b16509e7 Gerrit-Change-Number: 12586 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 13:57:53 +0000 Gerrit-HasComments: Yes
