Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12604 )
Change subject: Add timing information to /scans ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12604/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12604/1//COMMIT_MSG@14 PS1, Line 14: Screenshot: https://github.com/wdberkeley/kudu/blob/scanspage_screenshot/ss.png Curious that all of those scans didn't scan anything. Is that expected? Aren't those loadgen scans? It's probably worth differentiating `duration` from `timing`. They're similar but they seem pretty different in their values in the linked image -- my guess is `duration` is just that of a single request, and `timing` spans the lifetime of a scanner? If so, wdyt about calling them something like `request duration` and `scanner times` or somesuch? As is, it might be confusing that the scan duration was 31ms, but the timing shows 115ms walltime for the scanner. -- To view, visit http://gerrit.cloudera.org:8080/12604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30251557ae7f0d97e0d1328bd53511dae7a820b Gerrit-Change-Number: 12604 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 22:40:20 +0000 Gerrit-HasComments: Yes
