Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12604 )
Change subject: KUDU-2705: Add timing information to /scans ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12604/5/src/kudu/util/stopwatch.h File src/kudu/util/stopwatch.h: http://gerrit.cloudera.org:8080/#/c/12604/5/src/kudu/util/stopwatch.h@129 PS5, Line 129: struct CpuTimes { Nit: you might prefer to define a zero-arg constructor that calls clear(). It's functionally the same, but it reduces the number of places that need "initializers" from 2 to 1 (if we added a new field in the future). -- To view, visit http://gerrit.cloudera.org:8080/12604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30251557ae7f0d97e0d1328bd53511dae7a820b Gerrit-Change-Number: 12604 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 06 Mar 2019 05:17:29 +0000 Gerrit-HasComments: Yes
