Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12604 )
Change subject: KUDU-2705: Add timing information to /scans ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12604/2/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/12604/2/src/kudu/tserver/scanners.h@47 PS2, Line 47: #include "kudu/util/rw_mutex.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/12604/2/src/kudu/util/stopwatch.h File src/kudu/util/stopwatch.h: http://gerrit.cloudera.org:8080/#/c/12604/2/src/kudu/util/stopwatch.h@130 PS2, Line 130: nanosecond_type wall = 0; : nanosecond_type user = 0; : nanosecond_type system = 0; : int64_t context_switches > I noticed these don't have 0 initializers. Perhaps this is why you're getti Good catch. I added zero initializers and it made the goofiness go away. -- To view, visit http://gerrit.cloudera.org:8080/12604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30251557ae7f0d97e0d1328bd53511dae7a820b Gerrit-Change-Number: 12604 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 17:21:12 +0000 Gerrit-HasComments: Yes
