Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12604 )
Change subject: Add timing information to /scans ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12604/1/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/12604/1/src/kudu/tserver/scanners.h@434 PS1, Line 434: // The cumulative amounts of wall, user cpu, and system cpu time spent on : // this scanner, in seconds. : double wall_secs; : double user_secs; : double sys_secs; curious if you considered just using CpuTimes from stopwatch.h for this and adding an 'Add' method to that struct? http://gerrit.cloudera.org:8080/#/c/12604/1/src/kudu/tserver/scanners.h@466 PS1, Line 466: }; should probably have a DISALLOW_COPY_AND_ASSIGN so it isn't accidentally copied http://gerrit.cloudera.org:8080/#/c/12604/1/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/12604/1/src/kudu/tserver/tserver_path_handlers.cc@542 PS1, Line 542: duration can we somehow clarify in the UI the distinction between duration and wall_secs? I was also surprised to see in your screenshot several cases where 'real' reported in the timings was more than the 'duration'. How's that possible? http://gerrit.cloudera.org:8080/#/c/12604/1/www/scans.mustache File www/scans.mustache: http://gerrit.cloudera.org:8080/#/c/12604/1/www/scans.mustache@29 PS1, Line 29: running time of the scan" can we clarify how this differs from wall time? -- To view, visit http://gerrit.cloudera.org:8080/12604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30251557ae7f0d97e0d1328bd53511dae7a820b Gerrit-Change-Number: 12604 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 23:27:58 +0000 Gerrit-HasComments: Yes
