Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12516 )
Change subject: [tools] Add tool 'perf table_scan' ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12516/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12516/5//COMMIT_MSG@7 PS5, Line 7: [tools] Add tool 'perf table_scan' > I'm a little confused how this differs from just using 'kudu table scan' wi It's an advice from Will Berkeley in https://gerrit.cloudera.org/#/c/12167/ (patch set 15), not much differs, but for two difference use cases to reduce command flags. http://gerrit.cloudera.org:8080/#/c/12516/5/src/kudu/tools/table_scanner.h File src/kudu/tools/table_scanner.h: http://gerrit.cloudera.org:8080/#/c/12516/5/src/kudu/tools/table_scanner.h@78 PS5, Line 78: mutex cout_lock_; > oh, before looking at this patch, I also noticed the lack of lock here and Sorry I didn't find this bug before, you can merge that logically separate patch at first, I will rebase the master branch later. -- To view, visit http://gerrit.cloudera.org:8080/12516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibebed05d9a91ae3f126d3cf2d92f66852b253edd Gerrit-Change-Number: 12516 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 27 Feb 2019 06:18:03 +0000 Gerrit-HasComments: Yes
