Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12516 )
Change subject: [tools] Add tool 'perf table_scan' ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12516/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12516/5//COMMIT_MSG@7 PS5, Line 7: [tools] Add tool 'perf table_scan' > It's an advice from Will Berkeley in https://gerrit.cloudera.org/#/c/12167/ Yes, the rough history is: 1. The tool was originally proposed as `kudu perf table_scan` because Yingchun has a perf-related use case for it. 2. I thought it looked really useful for me, but as a tool to look at a few arbitrary rows or a few specific ones using predicates. 3. Then, using the power of goldfish memory, every time I went to use `kudu perf table_scan`, I was going to type `kudu table scan` first, and then have to look up where the scan tool actually lives. :( 4. I thought, why not have basically a "command synonym" with maybe a different default for a flag or two, to make both use cases accessible and obvious? -- To view, visit http://gerrit.cloudera.org:8080/12516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibebed05d9a91ae3f126d3cf2d92f66852b253edd Gerrit-Change-Number: 12516 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 27 Feb 2019 06:41:12 +0000 Gerrit-HasComments: Yes
