Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12516 )
Change subject: [tools] Add tool 'perf table_scan' ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/12516/9/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12516/9/src/kudu/tools/kudu-tool-test.cc@1809 PS9, Line 1809: "-run_scan" Nit: since --keep_auto_table has two dashes, please use two leading dashes here too. http://gerrit.cloudera.org:8080/#/c/12516/9/src/kudu/tools/table_scanner.h File src/kudu/tools/table_scanner.h: http://gerrit.cloudera.org:8080/#/c/12516/9/src/kudu/tools/table_scanner.h@55 PS9, Line 55: // Set snapshot timestamp for scans, or read the latest data if not set. : void SetSnapshot(uint64_t snapshot_timestamp); This doesn't appear to be used anymore, as the two TableScanner callers either do a default read (i.e. READ_LATEST) or call SetReadMode(READ_YOUR_WRITES). Could you remove it, and also wrap mode_ in boost::optional<> so that you don't need to default to READ_LATEST in TableScanner (but rather let the KuduScanner itself default to whatever ReadMode it wants)? -- To view, visit http://gerrit.cloudera.org:8080/12516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibebed05d9a91ae3f126d3cf2d92f66852b253edd Gerrit-Change-Number: 12516 Gerrit-PatchSet: 9 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 21 Mar 2019 18:34:33 +0000 Gerrit-HasComments: Yes
