Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12516 )
Change subject: [tools] Add tool 'perf table_scan' ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/12516/7/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12516/7/src/kudu/tools/kudu-tool-test.cc@438 PS7, Line 438: } : } : i > There are default values for `FLAGS_show_value`, for `table scan` it's `tru Yeah but the _test_ has no visibility into that; any default value overrides happen in the CLI tool, which runs in a separate process than this test. See for yourself: if you LOG the value of FLAGS_show_value here, I bet it'll always be the same, regardless of which test you ran. http://gerrit.cloudera.org:8080/#/c/12516/7/src/kudu/tools/table_scanner.h File src/kudu/tools/table_scanner.h: http://gerrit.cloudera.org:8080/#/c/12516/7/src/kudu/tools/table_scanner.h@64 PS7, Line 64: } : : pr > It is used in src/kudu/tools/tool_action_perf.cc, L584 Whoops, sorry I missed that. http://gerrit.cloudera.org:8080/#/c/12516/7/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/12516/7/src/kudu/tools/tool_action_perf.cc@575 PS7, Line 575: // It's necessary to have read-what-you-write behavior here. Since > TableScanner instance doesn't write anything itself, but the KuduClient ins Ah I see; CountTableRows is already being used by TestLoadGenerator, which indeed writes data. http://gerrit.cloudera.org:8080/#/c/12516/7/src/kudu/tools/tool_action_perf.cc@582 PS7, Line 582: RETURN_NOT_OK(scanner.Run()); If your consistency goal is to read-your-writes (which I think it is), you're better off using the READ_YOUR_WRITES ReadMode of KuduScanner. Then you don't need to propagate the timestamp yourself, nor do you need to specify a LEADER_ONLY read. -- To view, visit http://gerrit.cloudera.org:8080/12516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibebed05d9a91ae3f126d3cf2d92f66852b253edd Gerrit-Change-Number: 12516 Gerrit-PatchSet: 8 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 18 Mar 2019 17:56:05 +0000 Gerrit-HasComments: Yes
