Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12705 )
Change subject: [java] Allow delete operations with extra columns set ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12705/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12705/1//COMMIT_MSG@14 PS1, Line 14: With this patch, any non-key columns are stripped : when encoding the row. I'm curious why not to enforce the same requirements for the row at the client side as at the server, i.e. report an error instead of silently stripping all non-key columns. I understand that adds more restrictions, but it would be more consistent with the rest of the verification steps performed at the client side. Is there any motivation for this alternative approach that comes from real-world scenarios? -- To view, visit http://gerrit.cloudera.org:8080/12705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id302f349a35b9faf7382c74f9a3823f8e76f000c Gerrit-Change-Number: 12705 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 09 Mar 2019 00:38:23 +0000 Gerrit-HasComments: Yes
