Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12705 )
Change subject: [java] Allow delete operations with extra columns set ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12705/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12705/1//COMMIT_MSG@14 PS1, Line 14: With this patch, any non-key columns are stripped : when encoding the row. > I think it makes sense to keep the server-side verification strict to at le I think the client-side handling boils down to personal taste. I myself would have opted for stricter defaults with some additional tooling to support such cases. Meaning, the client would reject a DELETE with non-primary key data, but PartialRow offers the API Grant mentioned to drop non-primary key data. Taken together, we'd be able to support the use cases Grant mentioned while still preserving consistent behavior between the Java client and the server (as well as the Java client and the C++ client, which continues to send the raw data to the server and relies on its error handling). But this is fine too. I imagine Grant will extend this to the C++ client next, to keep its behavior consistent with the Java client. -- To view, visit http://gerrit.cloudera.org:8080/12705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id302f349a35b9faf7382c74f9a3823f8e76f000c Gerrit-Change-Number: 12705 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 Mar 2019 18:04:27 +0000 Gerrit-HasComments: Yes
