Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12705 )
Change subject: [java] Allow delete operations with extra columns set ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/12705/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12705/1//COMMIT_MSG@14 PS1, Line 14: With this patch, any non-key columns are stripped : when encoding the row. > Honestly my primary motivation is simplified testing. That said, I often fi I think it makes sense to keep the server-side verification strict to at least avoid accepting junk data from the client-side. Also, keeping server-side strict allows to spot unintended misuse of the API. For the client-side I think it's OK (or maybe even better?) to be more accommodating for use-cases coming from the real world. It's great that you can envision some use-cases that would benefit from this change. Maybe, Adar has some additional thoughts on what's good for the client side. -- To view, visit http://gerrit.cloudera.org:8080/12705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id302f349a35b9faf7382c74f9a3823f8e76f000c Gerrit-Change-Number: 12705 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 Mar 2019 17:35:47 +0000 Gerrit-HasComments: Yes
