Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12705 )
Change subject: [java] Allow delete operations with extra columns set ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12705/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12705/1//COMMIT_MSG@14 PS1, Line 14: With this patch, any non-key columns are stripped : when encoding the row. Honestly my primary motivation is simplified testing. That said, I often find things that are useful for testing can be useful in real world use cases too. I think supporting permissive deletes could simplify replication/cdc type use cases where data is read from one data store (maybe Kudu) and then written to Kudu. If we are strict, the user needs to project just the key columns in this process. We also don't currently have a good API to take an existing PartitalRow and drop all but the key columns. > I'm curious why not to enforce the same requirements for the row at the > client side as at the server I agree that the server can/should be more permissive too. Even with that the client side change reduces the message size on the wire. -- To view, visit http://gerrit.cloudera.org:8080/12705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id302f349a35b9faf7382c74f9a3823f8e76f000c Gerrit-Change-Number: 12705 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 Mar 2019 15:58:38 +0000 Gerrit-HasComments: Yes
