Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12516 )
Change subject: [tools] Add tool 'perf table_scan' ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc@349 PS10, Line 349: > Every scanner has a default ReadMode of READ_LATEST. If we honor that, Tabl Scanner has a default ReadMode of READ_LATEST, OK! http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/tool_action_perf.cc@697 PS10, Line 697: scanner.SetOutput(&cout); > Don't need this. Done http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/tool_action_table.cc@393 PS10, Line 393: scanner.SetOutput(&cout); > Or this. Done -- To view, visit http://gerrit.cloudera.org:8080/12516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibebed05d9a91ae3f126d3cf2d92f66852b253edd Gerrit-Change-Number: 12516 Gerrit-PatchSet: 14 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 23 Mar 2019 05:28:20 +0000 Gerrit-HasComments: Yes
