Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12516 )
Change subject: [tools] Add tool 'perf table_scan' ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.h File src/kudu/tools/table_scanner.h: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.h@41 PS10, Line 41: mode_(kudu::client::KuduScanner::ReadMode::READ_LATEST), Don't need this anymore. http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc@343 PS10, Line 343: CHECK(mode == KuduScanner::ReadMode::READ_YOUR_WRITES : || mode == KuduScanner::ReadMode::READ_LATEST); It's legal to use READ_AT_SNAPSHOT without a provided timestamp, so there's no ReadMode that's not valid here. http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc@349 PS10, Line 349: CHECK(mode_); Don't need this either. Just check that mode has been set before calling SetReadMode() below. http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/tool_action_perf.cc@697 PS10, Line 697: scanner.SetReadMode(KuduScanner::ReadMode::READ_LATEST); Don't need this. http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/tool_action_table.cc@393 PS10, Line 393: scanner.SetReadMode(KuduScanner::ReadMode::READ_LATEST); Or this. -- To view, visit http://gerrit.cloudera.org:8080/12516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibebed05d9a91ae3f126d3cf2d92f66852b253edd Gerrit-Change-Number: 12516 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 22 Mar 2019 04:11:33 +0000 Gerrit-HasComments: Yes
