Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12516 )
Change subject: [tools] Add tool 'perf table_scan' ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.h File src/kudu/tools/table_scanner.h: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.h@41 PS10, Line 41: total_count_(0), > Don't need this anymore. Done http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc@343 PS10, Line 343: mode_ = mode; : } > It's legal to use READ_AT_SNAPSHOT without a provided timestamp, so there's Done http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc@349 PS10, Line 349: RETURN_NOT_OK(client_->OpenTable(table_name_, &table)); > Don't need this either. Just check that mode has been set before calling Se mode_ is a none value if not call SetReadMode(), I'm confused where to check it? -- To view, visit http://gerrit.cloudera.org:8080/12516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibebed05d9a91ae3f126d3cf2d92f66852b253edd Gerrit-Change-Number: 12516 Gerrit-PatchSet: 11 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 22 Mar 2019 05:19:03 +0000 Gerrit-HasComments: Yes
