Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12516 )
Change subject: [tools] Add tool 'perf table_scan' ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/12516/10/src/kudu/tools/table_scanner.cc@349 PS10, Line 349: RETURN_NOT_OK(client_->OpenTable(table_name_, &table)); > mode_ is a none value if not call SetReadMode(), I'm confused where to chec Every scanner has a default ReadMode of READ_LATEST. If we honor that, TableScanner::SetReadMode is only needed to override READ_LATEST with READ_AT_SNAPSHOT or READ_YOUR_WRITES. So it's OK for mode_ to be boost::none, and the code below should be: if (mode_) { RETURN_NOT_OK(builder.SetReadMode(mode_.get())); } That way it will let the KuduScanTokenBuilder default to READ_LATEST unless the TableScanner client has asked for something else. -- To view, visit http://gerrit.cloudera.org:8080/12516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibebed05d9a91ae3f126d3cf2d92f66852b253edd Gerrit-Change-Number: 12516 Gerrit-PatchSet: 13 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 22 Mar 2019 17:47:05 +0000 Gerrit-HasComments: Yes
