Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 )
Change subject: authz: verify tokens on writes ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tserver/tablet_server_authorization-test.cc File src/kudu/tserver/tablet_server_authorization-test.cc: http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tserver/tablet_server_authorization-test.cc@203 PS3, Line 203: FLAGS_tserver_enforce_access_control = true; Duplicated? http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tserver/tablet_server_authorization-test.cc@1239 PS3, Line 1239: vector<WritePrivilegeType>({ WritePrivilegeType::INSERT }))); How does this work? Is this coerced into a WritePrivileges (i.e. a FixedBitSet)? Seems too magical; are you missing an 'explicit' on a constructor somewhere? BTW, if you added a FixedBitSet constructor that took an std::initializer_list, you could probably construct WritePrivileges directly here. http://gerrit.cloudera.org:8080/#/c/11754/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11754/2/src/kudu/tserver/tablet_service.cc@636 PS2, Line 636: public: : RpcTransactionCompletionCallback(rpc::RpcContext* context, : Response* response) : : co > Good point, probably wouldn't hurt in all cases. OK, though "rejecting" isn't necessarily the right verb since any failed transaction now fits the bill. -- To view, visit http://gerrit.cloudera.org:8080/11754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefa2215d528a64f525e04bec111b25f8bc17c086 Gerrit-Change-Number: 11754 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 26 Mar 2019 22:48:07 +0000 Gerrit-HasComments: Yes
