Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 )
Change subject: authz: verify tokens on writes ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tablet/transactions/write_transaction.cc File src/kudu/tablet/transactions/write_transaction.cc: http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tablet/transactions/write_transaction.cc@41 PS3, Line 41: #include "kudu/gutil/dynamic_annotations.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tserver/tablet_server_authorization-test.cc File src/kudu/tserver/tablet_server_authorization-test.cc: http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tserver/tablet_server_authorization-test.cc@203 PS3, Line 203: rpc::UserCredentials user; > Duplicated? Done http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tserver/tablet_server_authorization-test.cc@1239 PS3, Line 1239: vector<WriteOpDescriptor> batch({ > How does this work? Is this coerced into a WritePrivileges (i.e. a FixedBit Nice, I was fretting having to explicitly declare a WritePrivileges and pass it in. Done http://gerrit.cloudera.org:8080/#/c/11754/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11754/2/src/kudu/tserver/tablet_service.cc@636 PS2, Line 636: public: : RpcTransactionCompletionCallback(rpc::RpcContext* context, : Response* response) : : co > OK, though "rejecting" isn't necessarily the right verb since any failed tr Done http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11754/3/src/kudu/tserver/tablet_service.cc@1114 PS3, Line 1114: .write_privileges = privileges, > warning: std::move of the variable 'privileges' of the trivially-copyable t Done -- To view, visit http://gerrit.cloudera.org:8080/11754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefa2215d528a64f525e04bec111b25f8bc17c086 Gerrit-Change-Number: 11754 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 27 Mar 2019 00:30:21 +0000 Gerrit-HasComments: Yes
