Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 )
Change subject: authz: verify tokens on writes ...................................................................... Patch Set 4: (2 comments) a couple of nits http://gerrit.cloudera.org:8080/#/c/11754/4/src/kudu/tablet/transactions/write_transaction.h File src/kudu/tablet/transactions/write_transaction.h: http://gerrit.cloudera.org:8080/#/c/11754/4/src/kudu/tablet/transactions/write_transaction.h@296 PS4, Line 296: virtual Status Prepare() override; nit: drop 'virtual'? Also, if not changing the rest of OVERRIDE in this file, why bother changing it just for one method? That makes it look less uniform. http://gerrit.cloudera.org:8080/#/c/11754/4/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11754/4/src/kudu/tserver/tablet_service.cc@1114 PS4, Line 1114: .write_privileges = privileges, That's C99's extension, isn't it? I'm not sure we want it in our C++11-like code. Maybe, introduce appropriate constructor for WriteAuthorizationContext instead? -- To view, visit http://gerrit.cloudera.org:8080/11754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefa2215d528a64f525e04bec111b25f8bc17c086 Gerrit-Change-Number: 11754 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 27 Mar 2019 02:37:10 +0000 Gerrit-HasComments: Yes
