Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13264 )
Change subject: KUDU-2807 Crash when flush or compaction overlaps with another compaction ...................................................................... Patch Set 1: (1 comment) Would be great to test this. I am surprised mt-tablet-test didn't trigger the crash; could you take a look? http://gerrit.cloudera.org:8080/#/c/13264/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/13264/1/src/kudu/tablet/tablet.cc@1753 PS1, Line 1753: Status Tablet::HandleEmptyCompactionOrFlush(const RowSetVector& rowsets, Shouldn't we recompute the rowset height in the event of an empty compact/flush? -- To view, visit http://gerrit.cloudera.org:8080/13264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic255f0466aa2c158fa32e8e38428eddfcf901b99 Gerrit-Change-Number: 13264 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2019 17:34:09 +0000 Gerrit-HasComments: Yes
