Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13264 )
Change subject: KUDU-2807 Crash when flush or compaction overlaps with another compaction ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13264/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/13264/3/src/kudu/tablet/tablet.cc@1058 PS3, Line 1058: UpdateAverageRowsetHeight(); > To be honest, this is gotten to the point where I regret adding this metric I think it's a useful metric. When debugging performance issues we've generally wanted to know how poorly compacted the tablets are, and this gives us that. I'd say let's go back to decoupling UpdateAverageRowsetHeight from AtomicSwapRowSets{Unlocked}. Sure it's a little fragile in that we might forget to call it if we sprout new calls to swap the rowsets, but that seems pretty rare, and this way we get the locking behavior we want. -- To view, visit http://gerrit.cloudera.org:8080/13264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic255f0466aa2c158fa32e8e38428eddfcf901b99 Gerrit-Change-Number: 13264 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2019 19:01:23 +0000 Gerrit-HasComments: Yes
