Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13264 )
Change subject: KUDU-2807 Crash when flush or compaction overlaps with another compaction ...................................................................... Patch Set 2: (1 comment) Ah I see I forgot to post my comments on PS2. Anyway they are sort of superseded by my comment on this one so I'm deleting them. http://gerrit.cloudera.org:8080/#/c/13264/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/13264/3/src/kudu/tablet/tablet.cc@1058 PS3, Line 1058: > Restricting this call to the locked version of the function doesn't seem li To be honest, this is gotten to the point where I regret adding this metric. 1. It caused a bug because the relationship between the locking is tricky and surprising. 2. It's not clear how useful this metric is, it just seemed nice. 3. Now it seems like just to add in a snipper of code to update the metric it's necessary to do some refactoring of tricky code, or tolerate risk of the metric not being updated. Maybe we just shouldn't have this metric at all? -- To view, visit http://gerrit.cloudera.org:8080/13264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic255f0466aa2c158fa32e8e38428eddfcf901b99 Gerrit-Change-Number: 13264 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2019 16:48:24 +0000 Gerrit-HasComments: Yes
