Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13264 )
Change subject: KUDU-2807 Crash when flush or compaction overlaps with another compaction ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13264/3/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/13264/3/src/kudu/tablet/tablet.h@616 PS3, Line 616: void AtomicSwapRowSets(const RowSetVector &to_remove, > warning: function 'kudu::tablet::Tablet::AtomicSwapRowSets' has a definitio Done http://gerrit.cloudera.org:8080/#/c/13264/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/13264/3/src/kudu/tablet/tablet.cc@1058 PS3, Line 1058: UpdateAverageRowsetHeight(); > I think it's a useful metric. When debugging performance issues we've gener Done -- To view, visit http://gerrit.cloudera.org:8080/13264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic255f0466aa2c158fa32e8e38428eddfcf901b99 Gerrit-Change-Number: 13264 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 16:57:19 +0000 Gerrit-HasComments: Yes
