Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13266 )
Change subject: [dns_resolver] KUDU-2791 TTL cache in DNS resolver ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13266/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13266/1//COMMIT_MSG@7 PS1, Line 7: [resolver] TTL cache for DNS resolver > Add KUDU-2791 to the commit message. Done http://gerrit.cloudera.org:8080/#/c/13266/1//COMMIT_MSG@10 PS1, Line 10: the cache is enabled and its capacity is 1 MiByte, while cache's > Is there some logic you used to choose the default capacity and ttl? Did yo I added a few sentences trying to explain the choice. The functionality of the TTL cache w.r.t. entries expiration given various TTL values is covered by TTLCache's tests. -- To view, visit http://gerrit.cloudera.org:8080/13266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1bbd55a8231fd541d2087f9202f24e80bc79f0b Gerrit-Change-Number: 13266 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2019 19:10:55 +0000 Gerrit-HasComments: Yes
