Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13266 )
Change subject: [dns_resolver] KUDU-2791 TTL cache in DNS resolver ...................................................................... Patch Set 2: (2 comments) In and of itself this doesn't address KUDU-2791 because DnsResolver is only used in certain parts of the C++ client. You'll need to do some more refactoring (i.e. chase down all calls to HostPort::ResolveAddresses) for the cache to be used universally. http://gerrit.cloudera.org:8080/#/c/13266/2/src/kudu/util/net/dns_resolver.h File src/kudu/util/net/dns_resolver.h: http://gerrit.cloudera.org:8080/#/c/13266/2/src/kudu/util/net/dns_resolver.h@28 PS2, Line 28: #include "kudu/util/ttl_cache.h" Could you forward declare TTLCache instead? Or does that not work because of unique_ptr's rules around deleters? http://gerrit.cloudera.org:8080/#/c/13266/2/src/kudu/util/net/dns_resolver.cc File src/kudu/util/net/dns_resolver.cc: http://gerrit.cloudera.org:8080/#/c/13266/2/src/kudu/util/net/dns_resolver.cc@43 PS2, Line 43: Note that these aren't configurable via gflag in applications that embed the Kudu C++ client library. If you want them to be configurable, you'll need to add explicit C++ APIs for them. But we probably don't need to do that on day one. -- To view, visit http://gerrit.cloudera.org:8080/13266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1bbd55a8231fd541d2087f9202f24e80bc79f0b Gerrit-Change-Number: 13266 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2019 23:42:36 +0000 Gerrit-HasComments: Yes
