Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13266 )
Change subject: [dns_resolver] KUDU-2791 TTL cache in DNS resolver ...................................................................... Patch Set 2: > (2 comments) > > In and of itself this doesn't address KUDU-2791 because DnsResolver > is only used in certain parts of the C++ client. You'll need to do > some more refactoring (i.e. chase down all calls to > HostPort::ResolveAddresses) for the cache to be used universally. That's a good observation. For some reason, I naively assumed that all DNS resolution is done by DnsResolver, so I could easily get away with adding TTL cache there. But apparently, that's not the case. Probably, that means the DNS cache should be a singleton accessed by HostPort::ResolveAddresses(), or the code could be refactored to use DnsResolver elsewhere, but then it needs to have 'synchronous' mode or alike. -- To view, visit http://gerrit.cloudera.org:8080/13266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1bbd55a8231fd541d2087f9202f24e80bc79f0b Gerrit-Change-Number: 13266 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2019 03:59:33 +0000 Gerrit-HasComments: No
