Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13380
Change subject: [tool-test] scenario for ksck and unusual tserver flags ...................................................................... [tool-test] scenario for ksck and unusual tserver flags Added a test scenario to check how ksck works in case of collecting information from many tablets servers when tablet servers have 'unusual' run-time flags. This is to cover regressions for a race condition that existed in FetchInfoFromTabletServers() some time ago before it was fixed with d17f9fce684272df28e6291839f162b33796bc5c along with bringing other improvements. With this test, I verified that the version prior to the above mentioned patch is susceptible to the race as reported by AddressSantitizer: heap-buffer-overflow and double-free reproduced (~1 of 100): http://dist-test.cloudera.org//job?job_id=aserbin.1558386479.123305 Also, I verified that commenting out the guard that protects concurrent calls of emplace_back() on warning_messages in src/kudu/toolts/ksck.cc, FetchInfoFromTabletServers() method, ASAN catches SIGBUS (~1 of 100): http://dist-test.cloudera.org//job?job_id=aserbin.1558385919.118394 Change-Id: I16cf69b6f7d2fb59014df26601dfc30e124a52ee --- M src/kudu/tools/kudu-tool-test.cc 1 file changed, 62 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13380/1 -- To view, visit http://gerrit.cloudera.org:8080/13380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I16cf69b6f7d2fb59014df26601dfc30e124a52ee Gerrit-Change-Number: 13380 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]>
