Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13380 )
Change subject: [tool-test] add scenario for KUDU-2819 regressions ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13380/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13380/2//COMMIT_MSG@20 PS2, Line 20: ThreadSantitizer > "ThreadSanitizer" (and "AddressSanitizer", below). Done http://gerrit.cloudera.org:8080/#/c/13380/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13380/2/src/kudu/tools/kudu-tool-test.cc@4547 PS2, Line 4547: Status s = RunTool(Substitute("cluster ksck $0", master_addr), > RunActionStderrString to simplify? Done http://gerrit.cloudera.org:8080/#/c/13380/2/src/kudu/tools/kudu-tool-test.cc@4560 PS2, Line 4560: LOG(INFO) << "STDERR: " << err; > Was this for debugging? Should it be removed? Whoops, indeed. Good catch! -- To view, visit http://gerrit.cloudera.org:8080/13380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16cf69b6f7d2fb59014df26601dfc30e124a52ee Gerrit-Change-Number: 13380 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 17:46:20 +0000 Gerrit-HasComments: Yes
