Hello Will Berkeley, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13380
to look at the new patch set (#2).
Change subject: [tool-test] scenario for ksck and unusual tserver flags
......................................................................
[tool-test] scenario for ksck and unusual tserver flags
Added a test scenario to check how ksck works in case of
collecting information from many tablets servers when tablet
servers have 'unusual' run-time flags.
This is to cover regressions for a race condition that existed
in FetchInfoFromTabletServers() some time ago before it was
fixed with d17f9fce6 along with bringing other improvements.
With this test, I verified that the version prior to the above mentioned
patch d17f9fce6 is susceptible to the race as reported by sanitizers.
ThreadSantitizer (100% failure rate):
http://dist-test.cloudera.org/job?job_id=aserbin.1558485044.66856
AddressSantitizer (~1 out of 20 failed), reproducing double-free,
heap-buffer-overflow, memory leaks and friends:
http://dist-test.cloudera.org/job?job_id=aserbin.1558484756.62807
Also, I verified that commenting out the guard that protects concurrent
calls of emplace_back() on warning_messages in src/kudu/toolts/ksck.cc,
FetchInfoFromTabletServers() method:
AddressSantitizer (~1 out of 20 failed):
http://dist-test.cloudera.org/job?job_id=aserbin.1558485217.70253
ThreadSantitizer (100% failure rate):
http://dist-test.cloudera.org/job?job_id=aserbin.1558485274.73242
Change-Id: I16cf69b6f7d2fb59014df26601dfc30e124a52ee
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13380/2
--
To view, visit http://gerrit.cloudera.org:8080/13380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16cf69b6f7d2fb59014df26601dfc30e124a52ee
Gerrit-Change-Number: 13380
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
